Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare: RegisterAttributeWithDistinguishedComparer should resolve the comparer from within the IoC #6

Open
marco-bertschi opened this issue Nov 8, 2019 · 0 comments
Open

Compare: RegisterAttributeWithDistinguishedComparer should resolve the comparer from within the IoC #6

marco-bertschi opened this issue Nov 8, 2019 · 0 comments
Assignees
@marco-bertschi
Labels
Area:Compare Improvement

Comments

@marco-bertschi
Copy link
Contributor

At the moment, IEqualityComparerHelperRegistration.RegisterAttributeWithDistinguishedComparer take an IComparer<TComparer, TIntention> as argument. This is most likely wrong, since we may just resolve the comparer from the ioC from the generic type arguments which are passed into the method anyways.

  • Check if there is a use case where a comparer instance must be set from external
  • Document
  • Adjust tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marco-bertschi marco-bertschi

Labels
Area:Compare Improvement
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marco-bertschi