Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMT mode messes up pin 0 #22

Open
L0laapk3 opened this issue Mar 9, 2021 · 1 comment
Open

RMT mode messes up pin 0 #22

L0laapk3 opened this issue Mar 9, 2021 · 1 comment

Comments

@L0laapk3
Copy link

L0laapk3 commented Mar 9, 2021

Hi there

I've noticed that, when using GPIO 0, using fastled with RMT mode messes up this pin. After a little digging I've come to the conclusion that the problem is caused by these lines:

rmt_config_t rmt_tx = RMT_DEFAULT_CONFIG_TX(gpio_num_t(0), rmt_channel);
#else
rmt_config_t rmt_tx;
memset((void*) &rmt_tx, 0, sizeof(rmt_tx));
rmt_tx.channel = rmt_channel;
rmt_tx.rmt_mode = RMT_MODE_TX;
rmt_tx.gpio_num = gpio_num_t(0); // The particular pin will be assigned later

From a quick scan of the original fastled code, it seems like they dont set it to pin zero first (anymore) (https://github.com/FastLED/FastLED/blob/master/src/platforms/esp/32/clockless_rmt_esp32.cpp#L109) so an update would hopefully be all thats needed to resolve this :)

@L0laapk3
Copy link
Author

L0laapk3 commented Mar 9, 2021

PS. not entirely related, but also not worth making an entire issue over, but it would be nice to enclose the entire clockless_rmt_esp32.cpp file in #ifndef FASTLED_ESP32_I2S #endif to avoid having to mess around in multiple places to enable RMT mode :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant