feat: added flag to parse all lines instead of skipping some #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for creating this repo and making it publicly available. This PR is implementing a TO DO that was left in the should_skip_line function. Currently certain lines are skipped while parsing the full XML file with the goal of "de-noising" the output files. Now there is a new argument, an optional --all-lines flag, which, when used, will skip the should_skip_line function, i.e. all lines will be parsed. I ran the test to do regression testing for when the --all-lines flag is not specified. I did not add a new test for the new flag though. Lmk if you'd like me to do that.