Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG]: The connect bug on the basic example page #1655

Open
1 task done
zzc-1024 opened this issue Oct 25, 2024 · 3 comments
Open
1 task done

🐛 [BUG]: The connect bug on the basic example page #1655

zzc-1024 opened this issue Oct 25, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@zzc-1024
Copy link

Is there an existing issue for this?

  • I have searched the existing issues and this is a new bug.

Current Behavior

  • When I connect two nodes of the same handle type which is incorrect, it automatically changes the handle of the node connection.
  • The order of Handle connections will affect whether the connection can be successful.

Expected Behavior

  • When the user is connected incorrectly, the connection should be rejected.
  • Whether the connection is successful or not should be independent of the connection order.

Steps To Reproduce

website

_2024_10_25_20_15_46_977.mp4
_2024_10_25_20_17_33_906.mp4

Relevant log output

No response

Anything else?

No response

@zzc-1024 zzc-1024 added bug Something isn't working triage Awaiting triage labels Oct 25, 2024
@bcakmakoglu
Copy link
Owner

Thanks for the report. I’ll take a look once I’m back from vacation 👍

@bcakmakoglu bcakmakoglu removed the triage Awaiting triage label Oct 25, 2024
@bcakmakoglu
Copy link
Owner

What happens here is that with ConnectionMode.Loose (which is currently the default, although with 2.0 ConnectionMode.Strict will be the default mode) allows source <--> source and target <--> target connections but this requires handles to have a fixed id, otherwise VueFlow has to assume that the handle types that should be used are source <--> target (since the ids are null by default).

It's not great atm but a fix for this would be a breaking change, thus this will be fixed in 2.0 and not in any of the next patch/minor releases, sorry.

I'll keep this issue open to track it for the next major release though.

@zzc-1024
Copy link
Author

zzc-1024 commented Nov 1, 2024

Thank you for your patient answer.😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants