Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle undefined group properly #104

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix: handle undefined group properly #104

merged 1 commit into from
Sep 18, 2023

Conversation

mbystedt
Copy link
Contributor

No description provided.

@github-actions
Copy link

Backend coverage report

Coverage after merging fix/userObject into main will be
39.94%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   access-logs.middleware.ts100%100%100%100%
   account-permission.decorator.ts100%100%100%100%
   allow-owner.decorator.ts100%100%100%100%
   app.module.ts0%0%0%0%1, 10–19, 2, 20, 29, 29, 29, 3–5, 51, 51, 6, 8, 81, 83, 9
   constants.ts84.38%75%100%100%26, 28, 36, 36, 38–39, 41, 46, 55–56, 58, 60, 62, 64, 66
   main.ts0%0%0%0%1, 12, 15, 18, 2, 21, 27–28, 3, 31–32, 32–33, 35–36, 4, 41–43, 5, 57, 6–7, 72–73, 75, 77, 8–9
   roles.decorator.ts100%100%100%100%
src/audit
   audit-streamer.service.ts64.29%100%50%66.67%34–37
   audit.module.ts0%100%100%0%1, 11, 2–4
   audit.service.ts8.33%0%1.96%18.42%108–110, 117, 117, 139, 155, 157, 191, 207–208, 239, 255–256, 281, 293, 319, 329, 353, 36, 369, 37, 393, 405, 41–42, 429, 439–440, 440, 440, 442, 451–452, 46–47, 480–481, 481–482, 484, 486, 486, 486, 486–487, 487, 487, 487–488, 488, 488, 488–489, 489, 489, 489–490, 490, 490, 490–491, 491, 491, 491–492, 492, 492, 492–493, 493, 493, 493–494, 494, 494, 494, 506, 519, 528–529, 549–550, 568, 581–582, 592, 601, 610, 619, 622, 622, 635, 635–636, 639, 64, 640, 642, 642, 65, 655–657, 669–670, 684–685, 699, 699–700, 702, 72, 72, 98
src/auth
   auth.controller.ts26.67%0%0%44.44%17, 23, 33, 33, 33, 35, 37–38, 41–42, 42, 42–43, 48, 48, 51
   auth.module.ts0%100%0%0%1, 10–13, 15, 18–19, 2, 20, 3–4, 46, 5–9
   auth.service.ts100%100%100%100%
   broker-combined-auth.guard.ts39.13%0%33.33%50%22–23, 23, 23–24, 26, 31, 33, 33, 33–34, 36
   broker-jwt-auth.guard.ts27.78%0%33.33%35.90%33–34, 36–38, 40, 40–41, 45, 45–46, 48–49, 49–50, 54–55, 55–56, 58, 58, 58, 61, 65, 65, 67, 69–70, 76, 76, 76, 76–77, 77–78, 80, 82
   broker-jwt.dto.ts100%100%100%100%
   broker-oidc-auth.guard.ts23.19%0%33.33%34.88%104, 36–37, 37–38, 40–41, 41–42, 42, 42, 45, 48, 50, 54, 54–55, 57, 57, 57, 60–61, 66, 66, 66, 66, 66–67, 67, 67, 67, 67–68, 68, 68, 70, 74, 74–75, 78, 84, 84, 84–86, 86–87, 90, 96, 96–97
   broker-oidc-redirect.guard.ts37.50%100%0%42.86%12–15
   jwt.strategy.ts0%0%0%0%1, 10, 10, 10, 15–16, 18, 2–3, 30, 30–31, 31, 34, 4, 40, 40–41, 41, 44, 5, 50, 6, 9
   oidc.strategy.ts0%100%0%0%1, 12–13, 16, 2, 20, 23, 27, 3, 30, 40, 44–49, 55, 57
   session.serializer.ts0%100%0%0%1, 13, 2, 5, 7
src/collection
   account.service.ts18.75%0%20%22.58%100, 100, 102, 106–108, 112, 114–115, 117, 120, 124–125, 125–126, 129, 129, 131–132, 135, 135, 135–137, 137, 137, 137–138, 146–147, 149, 149, 151, 154, 158–159, 159–160, 162, 167, 28, 36–37, 41, 43, 47, 53, 53, 53, 53–54, 57, 66, 70, 73, 75–76, 81, 90, 97–98
   collection.controller.ts45.76%0%11.11%68.42%109, 109, 109, 109, 109, 109, 109, 115, 117, 139, 139, 139, 139, 139, 139, 139, 145, 153, 46, 58, 65, 73, 79, 96
   collection.module.ts0%100%100%0%1, 17, 2–9
   collection.service.ts33.33%100%20%40%11, 17, 24–25, 27, 42
   user-collection.service.ts22.86%0%20%33.33%22, 30, 30–31, 33, 40–42, 47, 52, 56, 56, 56–57, 57, 57, 57, 57, 63, 71, 71–72, 74
src/collection/dto
   collection-search-query.dto.ts46.67%100%0%63.64%12, 16, 20, 7
   collection-search-result.dto.ts0%100%100%0%10, 3
   user-import.dto.ts100%100%100%100%
   user-roles.dto.ts21.05%0%0%26.67%17, 20, 22, 22, 22, 25–29, 33, 36–37
src/graph
   graph.controller.ts46.94%0%7.69%64.71%100, 124, 140, 147, 155, 170, 173, 173, 34, 46, 57, 73, 80, 92
   graph.module.ts0%100%100%0%1, 14, 2–6
   graph.service.ts7.61%0%7.14%8.45%105–107, 113, 115, 121,

@mbystedt mbystedt merged commit 7ebce38 into main Sep 18, 2023
2 checks passed
@mbystedt mbystedt deleted the fix/userObject branch September 18, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants