From cbac6f8a644caabfcd2815894086ad8bc7607e17 Mon Sep 17 00:00:00 2001
From: Kristen Cooke <kristen@button.is>
Date: Fri, 27 Nov 2020 08:05:48 -0800
Subject: [PATCH] fix: replace quinary expression with a variable re-assignment

---
 .../Admin/ReportingYear/ReportingYearTable.tsx           | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/app/containers/Admin/ReportingYear/ReportingYearTable.tsx b/app/containers/Admin/ReportingYear/ReportingYearTable.tsx
index e22f209417..2470cf3a01 100644
--- a/app/containers/Admin/ReportingYear/ReportingYearTable.tsx
+++ b/app/containers/Admin/ReportingYear/ReportingYearTable.tsx
@@ -24,12 +24,9 @@ function getMostRecentlyClosedYear(query) {
     .sort((yearA, yearB) => {
       const yearACloseTime = defaultMoment(yearA.node.applicationCloseTime);
       const yearBCloseTime = defaultMoment(yearB.node.applicationCloseTime);
-
-      return yearACloseTime.isBefore(yearBCloseTime)
-        ? 1
-        : yearBCloseTime.isBefore(yearACloseTime)
-        ? -1
-        : 0;
+      let sortOrder = yearACloseTime === yearBCloseTime ? 0 : 1;
+      if (yearBCloseTime.isBefore(yearACloseTime)) sortOrder *= -1;
+      return sortOrder;
     });
   // Can edit only the most recently closed reporting period
   // (unless the next application window has already opened - prevents overlap):