From b295e14b2cbf3136b3aa1bbe824ac051f1a6dfe8 Mon Sep 17 00:00:00 2001 From: Brandon Bouchard Date: Mon, 31 Jul 2023 13:34:50 -0700 Subject: [PATCH] Refactor for better extendability. --- .../src/components/public/PIAFormTabs/review/index.tsx | 7 +++++-- src/frontend/src/utils/status.ts | 3 +++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/frontend/src/components/public/PIAFormTabs/review/index.tsx b/src/frontend/src/components/public/PIAFormTabs/review/index.tsx index 6bbf8403a..dd9c180d4 100644 --- a/src/frontend/src/components/public/PIAFormTabs/review/index.tsx +++ b/src/frontend/src/components/public/PIAFormTabs/review/index.tsx @@ -18,6 +18,7 @@ import PendingReview from './pendingReview'; import ViewProgramAreaReview from './viewProgramArea'; import EditProgramAreaReview from './editProgramArea'; import { YesNoInput } from '../../../../types/enums/yes-no.enum'; +import { statusList } from '../../../../utils/status'; export interface IReviewProps { printPreview?: boolean; @@ -196,6 +197,7 @@ const PIAReview = ({ printPreview }: IReviewProps) => { const review = { isAcknowledged: mpoAcknowledged, reviewNote }; stateChangeHandler(review, `mpo`, true); }; + return ( <>
@@ -300,8 +302,9 @@ const PIAReview = ({ printPreview }: IReviewProps) => { reviewForm.programArea?.selectedRoles.map( (role: string, index: number) => { return reviewForm.programArea?.selectedRoles && - (pia.status === PiaStatuses.FINAL_REVIEW || - pia.status === PiaStatuses.COMPLETE) ? ( + // eslint-disable-next-line no-non-null-asserted-optional-chain + statusList?.(pia)?.[pia?.status!]?.Pages?.review + .viewProgramAreaReviews ? (
{ Pages: { review: { accessControl: true, + viewProgramAreaReviews: true, }, }, Privileges: { @@ -414,6 +416,7 @@ export const statusList = (pia: IPiaForm | null): StatusList => { Pages: { review: { accessControl: true, + viewProgramAreaReviews: true, }, }, Privileges: {