Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GHCR container image build pipeline #123

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

jujaga
Copy link
Member

@jujaga jujaga commented Jan 4, 2024

Description

This PR focuses on implementing a parallel Github Actions based image builder. While the old Jenkins pipeline depends on the image built by the buildconfig, we will be transitioning away from using that and instead storing our container artifacts in ghcr.io. This also updates our unit testing GA to test on Node 16, 18 and 20.

  • 8a0a5c3 Implement GHCR container image build pipeline
  • fc2c1b8 Extract Dockerfile from BuildConfig template

SHOWCASE-2755

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the OpenAPI 3.0 v*.api-spec.yaml documentation (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

jujaga added 2 commits January 4, 2024 13:57
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@jujaga jujaga added the enhancement New feature or request label Jan 4, 2024
@jujaga jujaga self-assigned this Jan 4, 2024
Copy link

github-actions bot commented Jan 4, 2024

Coverage Report

Totals Coverage
Statements: 97.02% ( 750 / 773 )
Methods: 98.04% ( 100 / 102 )
Lines: 98.57% ( 415 / 421 )
Branches: 94% ( 235 / 250 )

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ghost
Copy link

ghost commented Jan 4, 2024

@kyle1morel kyle1morel merged commit b5f226e into master Jan 4, 2024
17 checks passed
@kyle1morel kyle1morel deleted the ci/image branch January 4, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants