Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatched borderRadius token name between Figma and npm #386

Closed
mkernohanbc opened this issue Jun 14, 2024 · 1 comment
Closed

Fix mismatched borderRadius token name between Figma and npm #386

mkernohanbc opened this issue Jun 14, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@mkernohanbc
Copy link
Contributor

mkernohanbc commented Jun 14, 2024

We have a mismatch between our Figma library and our code library in the name of this token:

  • Figma: layout.borderRadius.default
  • CSS: --layout-border-radius-medium

The final part of the token name was changed from medium to default in 3.0.0, based on feedback from user testing that suggested people were instinctively looking for a 'correct', 'standard' value.

Best guess at what happened here is that that change happened in Figma after the Tokens Studio export used to create the 3.0.0 npm build. The value is set to medium in the tokens.json output file: https://github.com/ty2k/design-system/blob/1f81f09aefe592bf9531f2419ca7865e3c2e6b64/packages/design-tokens/input/tokens.json#L461

In the next release of the design tokens package, we need to re-match these two tokens. We have two options:

@mkernohanbc mkernohanbc added the bug Something isn't working label Jun 14, 2024
@Philip-Cheung
Copy link

Philip-Cheung commented Jun 24, 2024

The easiest thing to do is to revert it back to medium. I won't be able to do it on TS because of that github link credentials bug (Tyler will need to unlink it again for me to do it). In the meantime, I can add a description on the token to say medium is the default radius.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants