Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button - additional padding and margin options #410

Open
mkernohanbc opened this issue Jul 18, 2024 · 0 comments
Open

Button - additional padding and margin options #410

mkernohanbc opened this issue Jul 18, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@mkernohanbc
Copy link
Contributor

mkernohanbc commented Jul 18, 2024

Feedback from developer.gov.bc.ca team on the button component:

You may need to account for left and/or right padding on the tertiary and link buttons so that they align with content appropriately (it kinda drives designers wild when it doesn't, and we found a lot of folks 'hacking' the buttons to align)

Additional note from @ty2k:

the tertiary buttons don't have a visible border, but they do have a hover state that gives them a grey background with the rounded corners like the primary/secondary buttons. The link button doesn't have a background that changes, but it still has that same padding? Do you figure both of those button options need a way for folks to say "no horizontal padding or "no padding on one side" to give folks the option to get alignments just so?

Suggested using css:after to implement hover state without changing the size of the component.

Need to investigate best way to give users option to override padding without completely breaking the component.

@mkernohanbc mkernohanbc self-assigned this Jul 18, 2024
@mkernohanbc mkernohanbc added the enhancement New feature or request label Jul 18, 2024
@mkernohanbc mkernohanbc changed the title Button - left/right padding options for tertiary and link button types Button - additional padding and margin options Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant