Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend - Special Resolution - Update behaviour for changing Rules #15475

Closed
zac-broitman opened this issue Feb 27, 2023 · 9 comments
Closed
Assignees
Labels

Comments

@zac-broitman
Copy link

zac-broitman commented Feb 27, 2023

  • As a user managing a coop
  • I want to update my coops rules
  • so that I can file my special resolution with BC Registries

Acceptance Criteria

Scenario 1: Viewing existing rules

  • GIVEN ... I am viewing the information for my coop
  • WHEN ... I navigate to the Rules section
  • THEN ... I should see the file name and upload date of the copy of rules on file for my coop
  • OR ... if there is no file in the system, then I should see a message that a paper copy is available

**Scenario 2: Available on paper only - Changing Rules and select to describe the change in special resolution **

  • GIVEN ... I have selected to change my rule with the option
  • WHEN ... I clicked the box : The rules have changed and I will describe those changes in the Special Resolution and Done
  • THEN ... I should be directed to the Special Resolution page for entering the required fields (Resolution Date, Resolution Text, Resolution Signature sections with Signing party and date signed.)
  • AND ... I should see a confirmation that Changes will be described in the special resolution text and I should be to proceed.

Scenario 3: Available on paper only - Changing Rules and select to upload a new rules PDF document

  • GIVEN ... I have selected to change my rules and upload a new PDF
  • WHEN ... I select the option to Upload a new rules PDF document
  • THEN ... I should see an interface to upload a new full set of the rules PDF document
  • AND ... I should be able to proceed and see a confirmation that Certified Rules.pdf with uploaded date.

Scenario 4: Changing Rules if there was a previous special resolution filed with a PDF attached since last uploaded file

GIVEN ... I am viewing the Rule section of my coop info
WHEN ... I select to change upload a new rules with note stated : This document was uploaded on (date). Please refer to the special resolution filed after this date to view any changes to the rules.
THEN ... I should see a confirmation with the Certified Rules.pdf with Uploaded date.
AND ... I should be able to proceed

Scenario 5: Changing Rules if there is previous Rules changed and described in special resolution

GIVEN ... I am viewing the Rule section of my coop info
WHEN ... I select to change my rules (The rules change was described in previous Rules Special Resolution with updated date.)
THEN ... I should see a confirmation that New changes will be describing in the special resolution text and I should be able to proceed

Design
https://preview.uxpin.com/53053d7aeb85fb29915f7afa596429aea4f2a964#/pages/161307728/simulate/sitemap


Link to DoR for a US/ Feature
https://github.com/bcgov/entity/blob/master/.github/ISSUE_TEMPLATE/DoR%20-%20Relationships.md
https://github.com/bcgov/entity/blob/master/.github/ISSUE_TEMPLATE/DoR%20-%20Entity.md

Link to the DoD for a US/ Feature
https://github.com/bcgov/entity/blob/master/.github/ISSUE_TEMPLATE/DoD%20-%20Relationships.md
https://github.com/bcgov/entity/blob/master/.github/ISSUE_TEMPLATE/DoD%20-%20Entity.md

@zac-broitman
Copy link
Author

@zac-broitman
Copy link
Author

This ticket to be split into frontend and backend tickets:

Frontend - 3 - Ticket TBD
Backend - 3 - Ticket TBD

@zac-broitman zac-broitman changed the title Update behaviour for changing Rules Frontend - Update behaviour for changing Rules Mar 9, 2023
@Jxio Jxio self-assigned this Mar 31, 2023
@ethantspitt
Copy link
Collaborator

ethantspitt commented Apr 6, 2023

For existing business types, 'view and change business info' , there's a delete button on the review and confirm page.
The UXPin is updated for consistency.

Screen Shot 2023-04-06 at 10.44.17.png

@jdyck-fw
Copy link
Collaborator

Please reach out to the entities team once this work has been completed and we can then tag it to a release.

@seeker25 seeker25 self-assigned this Apr 26, 2023
@seeker25
Copy link
Collaborator

seeker25 commented May 3, 2023

Not blocked by Minio, I've updated business-edit-ui to work with minio now.

@seeker25 seeker25 changed the title Frontend - Update behaviour for changing Rules Frontend - Special Resolution - Update behaviour for changing Rules May 5, 2023
@seeker25
Copy link
Collaborator

Putting this one in review - there will be some tweaks from code review, plus some UX tweaks

@Jxio Jxio removed their assignment May 17, 2023
@ethantspitt
Copy link
Collaborator

Thanks Travis! @seeker25 ,

Tested with CP1002511, added UXA observations:
https://preview.uxpin.com/53053d7aeb85fb29915f7afa596429aea4f2a964#/pages/162999485/simulate/sitemap

@seeker25
Copy link
Collaborator

seeker25 commented May 25, 2023

Note this ticket shouldn't be closed as done until the UX work stated above is done. Just moving into QA, because the UX doesn't affect the functionality of the filing.

@ethantspitt
Copy link
Collaborator

Thanks @seeker25 tested with CP1002511, reviewed all the changes, ticket can be mark as complete.

Two minor note for correction PR to look at 👀

  1. the sample special resolution PDF seems broken
    Screenshot 2023-06-06 at 9.58.42 AM.png

  2. spacing for the rules component: please make them equal spacing (reduce B to A)

Screenshot 2023-06-06 at 10.00.07 AM.png

@seeker25 seeker25 closed this as completed Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants