Namerequest UI - missing numbered option for restoring limited company

[severinbeauvais]

1. login
2. go to https://www.names.bcregistry.gov.bc.ca/
3. select action: reactivate
4. enter business = BC0013141 (historical BC limited)

Expected result: can see both named and numbered options

Actual result: can only see named option; numbered option (link to COLIN) is missing, ie

[tshyun24]

I notice that when I remove this if statement, we can see both named and numbered option. I am wondering what entity types does it defined as allowed for restoration/reinstatement?

[severinbeauvais]

I notice that when I remove this if statement, we can see both named and numbered option. I am wondering what entity types does it defined as allowed for restoration/reinstatement?

isSupportedRestoration is a function in common-mixin.ts. It compares the subject entity type with a feature flag that is currently declared as "BC" (Benefit Company) in our Dev environment (per LaunchDarkly).

This ticket says that a "BC Limited Company" (CR) does not have the numbered option. The FF does not include CR. However, I think the solution isn't to include CR in the FF, as that will break other functionality in the logic (for example, it will display "Restore Now" instead of "Go to Corporate Online").

I think the solution is to use isNumeredEntityType (same as New BC Business flow) to determine whether to show the CompanyType component. I haven't looked at the other logic that's involved here; this will require testing both "numberable" and "name-only" entity types, and both those supported in LEAR vs COLIN (per FF).

[tshyun24]

Should the numbered company option be the second one which have 3 lines of sentences or none of them?

[severinbeauvais]

Should the numbered company option be the second one which have 3 lines of sentences or none of them?

Use the existing company type component. When Numbered Company is selected, it should show the 3 bullets. If the supported-restoration-entities FF includes the subject entity then the action button should say, "Restore Now". Otherwise, the button should say, "Go to Corporate Online to Restore".

PS - Check with @yuisotozaki or @janisrogers on whether the action should be "restore" or "reactivate".

[tshyun24]

Confirmed with Yui, "restore now" is good.

Now it looks below for the supported-restoration-entities FF isn't include

And looks below for the FF include, which is benefit company

[severinbeauvais]

The first button above should say, "Go to Corporate Online to Restore".

[tshyun24]

[tshyun24]

@severinbeauvais
Hi Severin, I notice that the FF for supported-restoration-entities has changed today, previously only "BC", but now it has "BC CC UR UL". So it looks good for Limited Company now in the DEV. In this case should I still use supported-restoration-entities or use isNumeredEntityType to determine whether to show the CompanyType component?
Talked with Karim and he helped me with that.

[ozamani9gh]

Please be careful when you merge code into NameRequest/NameX API , this needs to be coordinated with NAMES TEAM, it may affect our release.

We need this to be ready for Release by end of day Monday October 30th now.

[severinbeauvais]

Omid, I created a Namerequest "Post WoN" release to tag tickets to for visibility. Do you have another way to keep track of Namerequest bug tickets that are ready to release?

PS We have another Namerequest ticket that will be ready to merge today or tomorrow, and which we would like to release.

[ozamani9gh]

@severinbeauvais at our standup we discussed not merging any more tickets, so Oge could compile release notes for ocm/distribution. can you hold off on merge.

if not, we need it as part of our release report, and then i need to notify Oge to add to her comms...can you please add this to ticket to NAMES 19.3 NameRequest release please

[severinbeauvais]

Sorry about that.

I've added this ticket to your release report.