Namex - Alteration - NR for Benefit to Limited Name Change is not working

[seeker25]

Working with Eve on this one, some weird results when fetching the name request for alteration types:

NR 5816323 - BC Benefit Company - BC to Benefit Conversion 
entity_type_cd: BC
legalType: BEN

NR 6500693 - BC Benefit Company - Benefit to BC Conversion
entity_type_cd: BC 
legalType: BEN      <---- THIS SHOULD BE BC

BC to Unlimited Liability Company Conversion (NR 7675982)
entity_type_cd: UL
legalType: ULC

NR 7597063 CCC - BC to CCC Conversion
entity_type_cd: CC
legalType: CC

The wrong legalType is coming back for Benefit -> BC, which is causing the error described in #18122

[seeker25]

@danaannab tagging you here so you're aware

[eve-git]

According to the request mappings, for BECR (Benefit to Limited Company alteration), the entity_type_cd is 'CR' and legal_type is 'BEN'
legal_type:
https://github.com/eve-git/namex/blob/main/api/namex/services/lookup/name_request_filing_actions.py#L128
entity_type:
https://github.com/eve-git/namex/blob/main/api/namex/services/name_request/utils.py#L100

[eve-git]

But in namerequest: https://github.com/eve-git/namerequest/blob/main/src/components/new-request/search-components/business-lookup-fetch.vue#L117

[eve-git]

in current code, entity_type_cd is from namerequest (UI) and legal_type is from namex (backend)

[seeker25]

Eve did an adjustment to the payload, I've added in another PR for LEAR - seems to be working again on DEV.

[eve-git]

@seeker25 Please let me know when to release. Thanks.

[eve-git]

PRs:
bcgov/namex#1468
bcgov/namerequest#739

[seeker25]

@eve-git I think LEAR updates every Tuesday in Test

[eve-git]

@seeker25 I will try to put it to the namex release on next Tuesday.

[eve-git]

steps to test UI:

1. create a NR for alteration (Alter from one BC business type to another)
2. choose a Beneficiary Corp and fill in "Find an existing business"
3. go through the whole process, after payment, the NR should NOT show as a BC Benefit Company (as NR 4493724 in TEST), instead it should be a 'BC Limited Company'.

The test for API change is with Entity team.

[eve-git]

Deployed to DEV and TEST.

Ready for testing.

[oanyahuru]

Tested following the steps outlined, the new company shows up as a BC limited company