Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth Web: implement Amalgamate Now button #18533

Closed
6 tasks done
severinbeauvais opened this issue Nov 10, 2023 · 5 comments
Closed
6 tasks done

Auth Web: implement Amalgamate Now button #18533

severinbeauvais opened this issue Nov 10, 2023 · 5 comments
Assignees
Labels

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Nov 10, 2023

  • change MBR button from "go to COLIN" to new functionality (remove arrow and tooltip)
  • create draft amalgamation filing using this NR - for regular amalgamation
  • redirect to Filings UI (entity dashboard - same as draft business/IA)
  • use FF if not already implemented that way
  • verify that an existing draft amalgamation can be resumed
    • existing code may be hard-coded for IAs and Regs; need to update this
  • verify that deleting draft amalgamation re-displays the NR (if a NR was used)
    • this is probably implemented in the Auth API (see affiliations endpoint)

Since the schema ticket is incomplete, look at expected data object here:
https://github.com/bcgov/business-create-ui/pull/583/files#diff-1e39c22aa8040eca1facfbe09d95e68148098507a0387ddd39aa304d9dfbab87

UXPin: https://preview.uxpin.com/7f4cfe5fe4b0ba15a83d518177efe82a08e99167#/pages/158977681/simulate/sitemap

But you only need to create the draft with the minimum data -- same as IA.

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Nov 21, 2023

I think you will probably need a new FF to dictate which amalgamation NRs lead to a draft filing and redirection to Filings UI (vs go to COLIN button).

I imagine it will be just like this flag (which is for the entity UIs) but in sbc-auth project:

Private Zenhub Image

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Nov 21, 2023

I just thought of another (small?) thing that needs to be updated in Auth Web: the following list (and any items in it) should support "Amalgamation Application" items:

Private Zenhub Image

And also verify "Resume Draft" for a draft amalgamation application.

If this is too much for this ticket, and/or requires some Auth API work, please create a new ticket in this epic for it.

@riyazuddinsyed
Copy link
Collaborator

I have found a few issues regarding the requirements of this ticket
https://app.zenhub.com/workspaces/entities-team-space-6143567664fb320019b81f39/issues/gh/bcgov/entity/18764
2)Clicking on Amalgamate Now from the Name Request is still redirecting to Colin.

@JazzarKarim
Copy link
Collaborator

JazzarKarim commented Nov 27, 2023

@riyazuddinsyed Riyaz, for number 1, it's being fixed in: https://app.zenhub.com/workspaces/entities-team-space-6143567664fb320019b81f39/issues/gh/bcgov/entity/18532

For number 2: This is being controlled with a FF. Are you testing in DEV or TEST? In DEV, only BENs are enabled. Anything else will go to COLIN. In TEST, nothing is enabled. So, everything will go to COLIN.

Also, for BENs in DEV, the button will give a HTTP 400 error since it's waiting for the BE to be setup: https://app.zenhub.com/workspaces/entities-team-space-6143567664fb320019b81f39/issues/gh/bcgov/entity/18460

@seeker25
Copy link
Collaborator

Awesome, I'll create a release and tag this ticket to it sometime tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants