Create UI: implement new Amalgamating Businesses component - Part IV - DO THIS LAST

[Mihai-QuickSilverDev]

This ticket is the last third of this new component.

This ticket can be started (but not finished) before #18640 is finished.

To do:

• fix these unit tests: 18788 Incremental work on business name options business-create-ui#600 (comment)
• anything else we forgot to do
  • (save/resume) done in 18535 - Save and Resume Draft Amalgamation business-create-ui#592
  • validation done in Create UI: more framework changes, validation, etc (DO THIS LAST IN CREATE UI) #18689
  • make sure that each business is completely re-fetched when a draft is resumed (Create UI - Re-fetch Businesses info of draft amalgamation #18960)
  • list here if there's more
• implement Business Status unit tests
• implement Business Table unit tests
• implement Business Table Summary unit tests
• implement Business Table rule evaluation unit tests FUTURE if time allows
• implement Amalgamation Mixin unit tests
• go back and fix broken code found by unit testing if needed

Notes:

• Test reg user vs staff validations
• Use parameterization to test many scenarios more easily
• All the validations have been grouped in the table located here:
  https://docs.google.com/document/d/1Dt2jzPA2SLtQO7Ns2aPCzVchGdv4YrYB/edit

[jdyck-fw]

https://docs.google.com/document/d/1Dt2jzPA2SLtQO7Ns2aPCzVchGdv4YrYB/edit

[severinbeauvais]

Test Notes

Honestly, there isn't much to UX assure or QA. Mostly I added a bunch of unit tests.

BUT... I did update a couple of TING rules and their messages. See the PR for details, or look here:

1. updated foreignUnlimited rule: https://github.com/bcgov/business-create-ui/blob/d8e76a07339393aabba28ad98f2a7ca5b53d2e18/src/mixins/amalgamation-mixin.ts#L96
2. updated foreignUnlimited2 rule: https://github.com/bcgov/business-create-ui/blob/d8e76a07339393aabba28ad98f2a7ca5b53d2e18/src/mixins/amalgamation-mixin.ts#L112
3. added foreignUnlimited3 rule: https://github.com/bcgov/business-create-ui/blob/d8e76a07339393aabba28ad98f2a7ca5b53d2e18/src/mixins/amalgamation-mixin.ts#L136
4. updated ERROR_FOREIGN_UNLIMITED message: https://github.com/bcgov/business-create-ui/blob/d8e76a07339393aabba28ad98f2a7ca5b53d2e18/src/components/Amalgamation/BusinessStatus.vue#L60
5. updated ERROR_FOREIGN_UNLIMITED3 message: https://github.com/bcgov/business-create-ui/blob/d8e76a07339393aabba28ad98f2a7ca5b53d2e18/src/components/Amalgamation/BusinessStatus.vue#L68

So... it might be worth trying to add TINGs that violate these rules to see them in action.

[severinbeauvais]

^^ I deleted a couple of comments related to environmental issues (not this ticket), which are now fixed.

[yuisotozaki]

Observation:
When adding CCC to a ULC amalg filing, it shows up differently non-staff and staff view. The tooltip is working fine.

[severinbeauvais]

Yui, the bug you found above is not related to this ticket per se. It is a "resume draft" issue. Karim will fix it in #19201.

[JazzarKarim]

Adding it as a checkbox in #19201

[severinbeauvais]

While testing staff vs non-staff, I found a race condition that can cause the UI to mis-interpret whether the TING is in LEAR or not. I will fix it as part of #19050 .

[yuisotozaki]

Ready for QA then.