Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate - Legal API: some filings are missing "displayName" #18713

Closed
severinbeauvais opened this issue Nov 22, 2023 · 2 comments
Closed
Assignees
Labels
bug Something isn't working ENTITY Business Team

Comments

@severinbeauvais
Copy link
Collaborator

I saw the following while looking at this entity:
https://dev.business.bcregistry.gov.bc.ca/CP0000840

Private Zenhub Image

The error message is displayed if the filing is missing a name, displayName, effectiveDate, submittedDate or status. In this case, displayName is null.

I am not sure if this is simply bad data in the Dev Postgres db, or whether some Production filings might have this issue. This needs a quick investigation and possibly a db script to fix it.

@severinbeauvais severinbeauvais added ENTITY Business Team bug Something isn't working labels Nov 22, 2023
@severinbeauvais
Copy link
Collaborator Author

Also, since the above filing is missing a documentsLink value, shouldn't it be "paper only = true"?

@jdyck-fw jdyck-fw changed the title Legal API: some filings are missing "displayName" Investigate - Legal API: some filings are missing "displayName" Nov 23, 2023
@argush3
Copy link
Collaborator

argush3 commented Nov 24, 2023

This isn't an issue. The example in the description is likely bad data in Dev.

I've verified that there are no CP conversion filings in PRD.

Also, conversion filings are only supported for firms in the new world.

PRD conversion filings:

legal_type filing_type cnt
GP conversion 3176
SP conversion 11520

This was referenced Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ENTITY Business Team
Projects
None yet
Development

No branches or pull requests

3 participants