Filings UI: NR error after filing an application

[severinbeauvais]

After filing an IA or registration (and eventually, amalgamation), Filings UI displays the filing in the ledger. At this time, the "new business" is still identified by its "Txxx" number (not its BC/FM number). This is a special IA/reg flow. In this flow, the NR that was used (if not a numbered company), is fetched. This step passes if the application is still pending, but fails if the application is Filed and Paid. It fails, presumably, because the NR has been unaffiliated as part of its consumption.

Private Zenhub Image

Private Zenhub Image

Potential solutions include:

1. since we do not know the NR's phone or email key, we could go back and add it to the filing JSON in Create UI; then in Filings UI we would have access to it
2. change the Legal API to not fail if the NR is consumed (assuming it's still affiliated, or despite it)
3. change Legal or Auth API to not un-affiliate the NR once consumed
4. see comments below

[severinbeauvais]

cc: @kzdev420 @PaulGarewal @seeker25 @Mihai-QuickSilverDev

[severinbeauvais]

Sample URLs that demonstate the error: (login as BCREG0020 or IDIR)

• BC Limited incorporation: https://test.business.bcregistry.gov.bc.ca/Tv9wTXMsf5?filing_id=393107&status=Q09NUExFVEVE
• Sole Prop registration: https://test.business.bcregistry.gov.bc.ca/TzrAdUHh8R?filing_id=393106&status=Q09NUExFVEVE
• BEN incorporation: https://test.business.bcregistry.gov.bc.ca/Tcc577W3gE?filing_id=393105&status=Q09NUExFVEVE
• it's surely the same for Coop incorporations, though I didn't test it

[severinbeauvais]

Potential solutions (cont):

4. change Filings UI to NOT fetch the NR once the application is completed or paid

^^ This is the solution that I am implementing in this ticket.

[severinbeauvais]

Test Notes

To see this working, you need to load an "application dashboard" (ie, using Txxx number) after a named incorporation/ registration/ amalgamation application is filed.

I have tested this locally, ie

The application dashboard:

The business dashboard for the same entity:

[severinbeauvais]

@riyazuddinsyed

I verified this in Dev (https://dev.business.bcregistry.gov.bc.ca/Ty2i5TVeku?filing_id=147244&status=Q09NUExFVEVE).

I have also verified this in Test -- you can try loading the 3 URLs above that previously failed.