-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create UI: resulting business name UI changes #19136
Comments
Test NotesYou can use the same sample links as in #18788, or see the samples below. Sample Named BC AmalgamationSample Adopted BC AmalgamationSample Numbered BC Amalgamation |
@severinbeauvais The named example should show Resulting Business Name instead of Name Request as the label and should show the name on the first line with the the NR number below. For the numbered amalgamation, assuming the resulting business name and the first bullet will change based on the resulting business type, then all of the rest of this looks good to me. |
The following screenshot is the way the existing common component works. I'd prefer to change it for all filings or not at all, instead of having a special case just for amalgamations.
Yes, they will. Examples: BC companyULCCCC |
These changes are the result of UX Assurance for #18788.
From Janis:
Here are my findings:
The numbered CCC didn't work for me.The link to the sample draft CCC amalgamation didn't work because the draft was deleted. I provided a new link that works and Janis verified it successfully.The initial view should not have the 'Done' and 'Cancel' buttons. They should appear within the selected option once it is selected.Yui and I discussed this. The whole "options" component is a shared component and that's the way it works, so we decided to not change it at this time. If it is required to change this, it will affect the other places this shared component is imported (which is not necessarily a bad thing but will require a bit of extra dev time and test time).The text was updated successfully, but these errors were encountered: