Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Data Clearing Issues #19499

Closed
4 tasks done
mstanton1 opened this issue Jan 25, 2024 · 10 comments
Closed
4 tasks done

UI - Data Clearing Issues #19499

mstanton1 opened this issue Jan 25, 2024 · 10 comments
Assignees
Labels
Assets bug Something isn't working

Comments

@mstanton1
Copy link
Collaborator

mstanton1 commented Jan 25, 2024

Issue moved over from #18313 (I still see this)

  • Data is not clearing Issue 1:

  • Start a transport permit for MHR 107948 (or MHR 107956)

  • Select "Transport Permit"

  • Noticed issues for the 3 location types under "Other Land";

  1. "Indian Reserve", "Strata" and "Other";
  • There was leftover data in a number of the fields.
  1. for "Strata" and "Other";
  • These radio button options with PID numbers should always start with the Default view (PID Number), but they are both starting out with the manual legal land description view expanded

Screen Shot 2024-01-22 at 1.14.17 PM.png

Screen Shot 2024-01-22 at 2.06.29 PM.png

Screen Shot 2024-01-22 at 2.10.30 PM.png


Data is not clearing and sometimes info missing when using breadcrumb / Bug Issue 2:

  • If I use the breadcrumb to cancel out of a Transport Permit, the data is not getting cleared and sometimes the read-only location information disappears altogether

  • I opened MHR 107956

  • started a Transport Permit and entered Doc ID, and filled in some location information

  • Then I left the transport permit screen altogether by clicking the breadcrumb (back arrow or the Asset Registries link)

  • I am returned to Assets Dashboard

  • If I open MHR 107956 again

  • then sometimes the read-only location information is missing completely

  • and when I click "transport permit / change location" button

  • then the Doc ID data I had entered previously is still there.

step 1:
Screen Shot 2024-01-23 at 1.58.48 PM.png

step 2:
Screen Shot 2024-01-23 at 1.57.20 PM.png

step 3:
Screen Shot 2024-01-23 at 1.59.57 PM.png

step 4:
Screen Shot 2024-01-23 at 2.08.37 PM.png


Review and Confirm button Validation Bug TL: Unable to reproduce - will keep an eye out:

  • I opened MHR 107954
  • I started a transport permit
  • Before I filled in all the required fields, I click Review and Confirm button to trigger validations
  • Then I filled out all the remaining required information
  • But even though I filled everything out, the "please complete required information" error was still displaying under the Review and Confirm button when it should have been cleared as soon as all required information was completed:

Issues with "Transport Permit moving within a Manufactured Home Park"

  • missing review and confirm button validation
  • I opened MHR 107960
  • Then started a Transport Permit moving within a Manufactured Home Park
  • and erased the existing Pad number
  • I saw the required field validation under the Pad number field, but when I clicked Review and Confirm I wasn't stopped
  • I should have been stopped and seen the "please complete required information" message under the button

  • Not a Validation, not sure where to put this - Fee Summary text for "Transport Permit moving within a Manufactured Home Park"
  • Fee Summary should just say "Transport Permit" even when users select "moving within manufactured home park"

Screen Shot 2024-01-23 at 3.08.55 PM.png

@mstanton1
Copy link
Collaborator Author

@dimak1 I reviewed Tracey's list in greater detail. This is a lot of work for you. I think the data clearing issues are the most concerning. The other autoscroll/validation/error etc type fixes are important but could go after the Feb 6th release (even next sprint). Given the scope would you like me to split this into 2 tickets (one for this sprint and another that could be at the top of the backlog for next)?

cc @arlentees @tlebedovich

@PCC199 PCC199 added the bug Something isn't working label Jan 26, 2024
@mstanton1
Copy link
Collaborator Author

mstanton1 commented Jan 26, 2024

@dimak1 https://app.zenhub.com/workspaces/assets-team-space-new-655515cb02e714000e74f9f3/issues/gh/bcgov/entity/19536 has been created as a placeholder for some of these items. The ones that are not specific to Transport Permit and must be handled globally can be moved over (or at least a portion) to make this ticket a more manageable scope.

cc @arlentees

@dimak1
Copy link
Collaborator

dimak1 commented Jan 26, 2024

@mstanton1 I cleaned up the ticket and moved some of the items to #19536. The items in this ticket are related to Transport Permits, and I'm working to fix them right now. They are not complex issues, so the estimate is at 2. Can I pull this into the sprint?

@dimak1 dimak1 changed the title UI - Location Type and Civic Address Component Updates UI - Data Clearing Issues Jan 26, 2024
@mstanton1
Copy link
Collaborator Author

Absolutely! Thank you for separating these and providing the estimate:)

cc @arlentees

@dimak1 dimak1 self-assigned this Jan 26, 2024
@dimak1
Copy link
Collaborator

dimak1 commented Jan 26, 2024

These issues are fixed and could be verified using the same preview url as error validations: https://bcregistry-assets-dev--pr-1701-vxe8fau5.web.app/

@dimak1
Copy link
Collaborator

dimak1 commented Jan 26, 2024

I had to merge the fixes and error validations because they are required for the Review & Confirm page. So you can do UXA in DEV @tlebedovich

@chdivyareddy
Copy link
Collaborator

Verified in DEV for both staff and QS versions:

Scenario 1:

  • Data is not retained/cleared for the other land location types:

image.png

image.png

image.png

Scenario 2:

  • Location information is reset in the transport permits when user returns to the dashboard by clicking the breadcrumb (back arrow or the Asset Registries link)

image.png

Scenario 3:

  • When user selects "Transport Permit - Moving within the same Manufactured Home Park" and erases the pad number, then the validation is displayed when user tries to navigate to the Review screen and stops user from navigating:

image.png

@dimak1
Copy link
Collaborator

dimak1 commented Jan 30, 2024

@chdivyareddy working on these items

@dimak1
Copy link
Collaborator

dimak1 commented Jan 30, 2024

@chdivyareddy looks like these scenarios are not issues?

@chdivyareddy
Copy link
Collaborator

@dimak1 , oh no..I commented with screenshots that those scenarios were verified:) Those are not issues..

@PCC199 PCC199 closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assets bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants