-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create UI: no error displayed when changing holding/primary business fails #19750
Comments
@severinbeauvais Another one FYI.... |
@riyazuddinsyed You have blocked a network call. Is this a valid scenario? Did you see any messages (eg, in snackbar at bottom of the screen)? Are there any console messages? There should be both. |
@riyazuddinsyed Please tag tickets to the respective epic(s). I have done it for you this time and last time. |
@riyazuddinsyed Change the Holding company and in the network tab block the director call. |
@severinbeauvais @Mihai-QuickSilverDev I blocked the network tab which the users won't be able to do, but my intent here is if by any case the directors call fails there is no message that the UI throws. |
OK, so, the code was written to display an error (in this case, a message in the snackbar at the bottom of the screen) but that isn't working, so we can use this bug ticket to fix that. |
@riyazuddinsyed @yuisotozaki @NaveenHebbale What kind of error notification would you like to see if a network call failed while trying to mark a different TING as primary/holding? Is the following enough? |
(Old title: "vertical and horizontal Amalg's showing wrong directors in few scenarios.")
Describe the bug in the current situation
When the users start a Vertical or Horizontal amalgamation, then the Add Peoples show the current directors of the holding company. If the user changes the Holding company to another TING business then if the GET director call fails the directors of the old Holding company show up.
Steps to reproduce the behavior:
The text was updated successfully, but these errors were encountered: