Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UI: no error displayed when changing holding/primary business fails #19750

Closed
riyazuddinsyed opened this issue Feb 7, 2024 · 7 comments
Assignees
Labels
bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. ENTITY Business Team Priority2

Comments

@riyazuddinsyed
Copy link
Collaborator

riyazuddinsyed commented Feb 7, 2024

(Old title: "vertical and horizontal Amalg's showing wrong directors in few scenarios.")

Describe the bug in the current situation
When the users start a Vertical or Horizontal amalgamation, then the Add Peoples show the current directors of the holding company. If the user changes the Holding company to another TING business then if the GET director call fails the directors of the old Holding company show up.

Steps to reproduce the behavior:

  1. Go to 'https://dev.account.bcregistry.gov.bc.ca/account/2079/business'
  2. Login with BCREGA001/98900001
  3. Start a Vertical or Horizontal Amalg
  4. Change the Holding company and in the network tab block the director call.
  5. Now move to the Add People and Roles page.
  6. Observe that the UI instead of showing the error just shows the Directors of the previous Holding company.
@riyazuddinsyed riyazuddinsyed added bug Something isn't working ENTITY Business Team labels Feb 7, 2024
@Mihai-QuickSilverDev
Copy link
Collaborator

@severinbeauvais Another one FYI....

@severinbeauvais
Copy link
Collaborator

@riyazuddinsyed You have blocked a network call. Is this a valid scenario?

Did you see any messages (eg, in snackbar at bottom of the screen)? Are there any console messages? There should be both.

@severinbeauvais
Copy link
Collaborator

@riyazuddinsyed Please tag tickets to the respective epic(s). I have done it for you this time and last time.

@Mihai-QuickSilverDev
Copy link
Collaborator

@riyazuddinsyed Change the Holding company and in the network tab block the director call.
Is this a realistic scenario that could happen from the UI interface? Even for UI users?

@Mihai-QuickSilverDev Mihai-QuickSilverDev added the Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. label Feb 8, 2024
@riyazuddinsyed
Copy link
Collaborator Author

@severinbeauvais @Mihai-QuickSilverDev I blocked the network tab which the users won't be able to do, but my intent here is if by any case the directors call fails there is no message that the UI throws.

@severinbeauvais
Copy link
Collaborator

OK, so, the code was written to display an error (in this case, a message in the snackbar at the bottom of the screen) but that isn't working, so we can use this bug ticket to fix that.

@severinbeauvais severinbeauvais changed the title vertical and horizontal Amalg's showing wrong directors in few scenarios. Create UI: no error displayed when changing holding/primary business fails Feb 8, 2024
@severinbeauvais severinbeauvais self-assigned this Feb 13, 2024
@severinbeauvais
Copy link
Collaborator

@riyazuddinsyed @yuisotozaki @NaveenHebbale What kind of error notification would you like to see if a network call failed while trying to mark a different TING as primary/holding? Is the following enough?

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. ENTITY Business Team Priority2
Projects
None yet
Development

No branches or pull requests

4 participants