Create UI: Resulting business name not updated if primary/holding name was changed in the background

[riyazuddinsyed]

Original title: "Resulting business name doesn't align with the Notice of Articles of the holding name when an Alteration is filed."

Describe the bug in the current situation
When the amalgamation is in progress or say in draft state and if in case the user makes a name change using an Alteration for say Numbered to Named then in the Amalgamation filing upon resume draft the Amalgamating business table shows the name change while as the Resulting business name doesnt chnage the name as per the NOA.

Steps to reproduce the behavior:

1. Go to 'https://dev.bcregistry.gov.bc.ca/?accountid=2079'
2. Login with BCREGA001/98900001
3. Search the Draft Amalgamation filing for the company 0871305 B.C. LTD.
4. Now under the primary business notice the name in the Amalgamating table and the name in the Resulting business name section.

Screenshots/ Visual Reference/ Source

[severinbeauvais]

deleted obsolete comment due to new comment below

[severinbeauvais]

There are 2 cases to handle:

1. The holding/primary business name (or legal type!) has changed and the user reloads the draft amalgamation. To handle this case, when the draft is reloaded then we need to reload the resulting business name.

2. The holding/primary business name (or legal type!) has changed and the user tries to submit the still-open amalgamation. To handle this case, when the filing is submitted then we need to reload the resulting business name.

(Note that the Filer ignores the legal name in the filing JSON and looks up the legal name of the holding/primary name anyway.)

There is already an "update prepopulated data" method that is called in the 2 cases above, but a small code tweak is needed. I will do that in this ticket and verify all cases.

cc: @OlgaPotiagalova

[severinbeauvais]

Test Notes

I tested the following on a horizontal and vertical amalgamation:

1. open 2 copies of the amalgamation
2. in the background, change the name of the holding/primary business
3. reopen (resume/refresh) one copy of the amalgamation, and verify that the holding/primary business' name has changed and also the amalgamation's resulting business name
4. click File and Pay to submit the other copy of the amalgamation, and verify that the holding/primary business' name has changed and also the amalgamation's resulting business name (if you want, you can leave the amalgamation incomplete so that File and Pay refreshes the data but the filing is not actually submitted)

I also tested, in a regular amalgamation, that a TING's name is updated in the business table (if it was changed in the background) when the user clicks File and Pay to submit the amalgamation.

[severinbeauvais]

Test Notes (cont)

I also tested that changing the type of the holding/primary business in the background is caught when the user clicks File and Pay to submit the filing, as follows:

1. create a short-form amalgamation from a CCC business (which makes the amalgamation a CCC and sets the business as the holding/primary)
2. add a Benefit Company and mark this BEN as the new holding/primary); this causes a table error because a CCC must be the holding/primary
3. fill out the rest of the amalgamation and try to submit it -- observe the table error
4. in the background, change the BEN to a CCC
5. come back to the amalgamation and try to submit it -- observe that submission now succeeds because the table error was resolved because the holding/primary, which was previously a BEN, is now a CCC

[yuisotozaki]

Good catch, this.
Ready for QA.