Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UI: Clicking on Edit button of completing party is showing up directors and allowing to change. #19805

Closed
riyazuddinsyed opened this issue Feb 13, 2024 · 2 comments
Assignees
Labels
bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. ENTITY Business Team

Comments

@riyazuddinsyed
Copy link
Collaborator

Describe the bug in the current situation
When the user clicks on the Edit button of the completing party, then the directors show up instead of completing party.

Steps to reproduce the behavior:

  1. Go to 'https://test.create.business.bcregistry.gov.bc.ca/'
  2. Login using BCREGA001/98900001
  3. Start a Short-form Amalgamation.
  4. Add a completing party.
  5. Now click on the Edit button of the completing party
  6. Notice that the Director info shows up instead of Completing Party Info.
@riyazuddinsyed riyazuddinsyed added bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. ENTITY Business Team and removed Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. labels Feb 13, 2024
@severinbeauvais severinbeauvais changed the title Clicking on Edit button of completing party is showing up directors and allowing to change. Create UI: Clicking on Edit button of completing party is showing up directors and allowing to change. Feb 14, 2024
@severinbeauvais severinbeauvais self-assigned this Feb 14, 2024
@severinbeauvais
Copy link
Collaborator

I have confirmed that editing (and probably reviewing) the completing party uses the wrong index and thus acts on the wrong party (ie, a director instead of the completing party).

@NaveenHebbale NaveenHebbale added the Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. label Mar 5, 2024
@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Mar 5, 2024

I verified this in our Test environment (as per steps above).

  • editing the completing party displays the correct completing party record (not a director that was inherited from the TED business)
  • saving a change to the completing party correctly updated the correct record
  • the review and confirm page correctly shows the directors and completing party (and completing party is not the first record)

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. ENTITY Business Team
Projects
None yet
Development

No branches or pull requests

3 participants