Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE - Comment out 1password update section by Oct 1, 2024 #23222

Closed
5 tasks done
chenhongjing opened this issue Sep 10, 2024 · 3 comments
Closed
5 tasks done

BE - Comment out 1password update section by Oct 1, 2024 #23222

chenhongjing opened this issue Sep 10, 2024 · 3 comments
Assignees
Labels
Entities - David A label to filter on the tickets for the Entities based team that David is PO for. ENTITY Business Team High Priority techdebt

Comments

@chenhongjing
Copy link
Collaborator

chenhongjing commented Sep 10, 2024

We use 1Password CLI1 to push config values to our OCP services when we deploy them right now. But 1Password CLI1 will be deprecated on Oct 1, 2024. It means that applications deployed on OCP will be affected. Since we will move to GCP very soon and the new CD pipeline for GCP already supports CLI2, we need to manually update configs for services temporarily staying on OCP after Oct 1.

TODOs

  • Start work from one component, after the change is verified, do for the others
  • Comment out the vault update section in Makefile for all BE components
  • Comment out any related sections
  • Verify the changes work for all BE components deployed on OCP
  • Talk to Patrick if you need help on troubleshooting issues when working on this

Note that if we need to add/update/remove configs after this change, remember to do it manually for all of dev/test/prod.

@chenhongjing chenhongjing added Entities - David A label to filter on the tickets for the Entities based team that David is PO for. ENTITY Business Team techdebt labels Sep 10, 2024
@chenhongjing chenhongjing changed the title BE - Upgrade to use 1Password CLI version 2 by Oct 1, 2024 BE - Comment out 1password update section by Oct 1, 2024 Sep 10, 2024
@kzdev420 kzdev420 self-assigned this Sep 18, 2024
@vishnup0422
Copy link
Collaborator

The docker file is updated and 1password variables are commented out.

@chenhongjing
Copy link
Collaborator Author

chenhongjing commented Sep 25, 2024

It's incomplete and it only modified the legal-api. Should be moved back to in progress to finish the rest of the components... @kzdev420 @vishnup0422

@vishnup0422
Copy link
Collaborator

vishnup0422 commented Oct 2, 2024

The 1Password variables and updates have been commented in all the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entities - David A label to filter on the tickets for the Entities based team that David is PO for. ENTITY Business Team High Priority techdebt
Projects
None yet
Development

No branches or pull requests

5 participants