Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR UI: should not call PATCH after failed GET #7238

Closed
severinbeauvais opened this issue Apr 19, 2021 · 2 comments
Closed

NR UI: should not call PATCH after failed GET #7238

severinbeauvais opened this issue Apr 19, 2021 · 2 comments
Labels
bug Something isn't working Name Request Names Team Name Request Name Examination Team

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Apr 19, 2021

Describe the bug in current situation
According to this Sentry issue, the NR UI does a PATCH call (to update a NR) after a GET call failed.

The failed GET call should stop whatever processing is going on.

Calling PATCH with invalid data (due to failed GET) could save corrupt data in the db and/or overwrite valid data. These errors happened on the checkout call, so cannot corrupt data. However, I am not sure what the app does after this error occurs: Does it force the user to restart from the beginning? Or does it happily continue as if nothing happened, and possibly allow a subsequent checkin... I don't know; the priority should depend on this.

Link bug to the User Story

Impact of this bug
Describe the impact, i.e. what the impact is, and number of users impacted.

Chance of Occurring (high/medium/low/very low)

Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?

Steps to Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Actual/ observed behavior/ results

Expected behavior
A clear and concise description of what you expected to happen. Use the gherking language.

Screenshots/ Visual Reference/ Source
If applicable, add screenshots to help explain your problem. You an use screengrab.

@severinbeauvais severinbeauvais added bug Something isn't working ENTITY Business Team Name Request Priority1 and removed Priority1 labels Apr 19, 2021
@jdyck-fw
Copy link
Collaborator

This is a timebox to review code and verify if this is an issue, and then fix it if it is.

@jdyck-fw jdyck-fw added the SRE SRE team task label Dec 2, 2021
@pwei1018 pwei1018 added Names Team Name Request Name Examination Team and removed SRE SRE team task labels Oct 6, 2023
@ozamani9gh
Copy link
Collaborator

Old Sentry issue. closing because need recent error message to investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Name Request Names Team Name Request Name Examination Team
Projects
None yet
Development

No branches or pull requests

5 participants