Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namex API: Invalid state transition #8081

Closed
severinbeauvais opened this issue Jun 30, 2021 · 6 comments
Closed

Namex API: Invalid state transition #8081

severinbeauvais opened this issue Jun 30, 2021 · 6 comments
Assignees
Labels
blocked bug Something isn't working ENTITY Business Team Names Team Name Request Name Examination Team NameX NameX and related services proxied via namex Priority2

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Jun 30, 2021

Describe the bug in current situation
The Namerequest UI reported a HTTP 500 error in which the Namex API experienced "Invalid state transition [REJECTED] -> [INPROGRESS], valid states are [DRAFT, INPROGRESS]".

See Sentry log: https://sentry.io/organizations/registries/issues/2138028243/events/40c5fe935b874f8ab5f89a15c4345d52/?project=5433955

The call that failed was: PATCH https://namex.apps.silver.devops.gov.bc.ca/api/v1/namerequests/2124356/checkout

The subject NR id is: NR 5198093

Link bug to the User Story
None

Impact of this bug
The user was unable to do something.

Chance of Occurring (high/medium/low/very low)
This seems to occur 0 up to a few times a day for at least the last 30 days in Production.

Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
Unknown

Steps to Reproduce
According to the Sentry breadcrumbs, the user was attempting to edit their existing NR.

Actual/ observed behavior/ results
See Sentry log.

Expected behavior
User can edit a NR without errors.

Screenshots/ Visual Reference/ Source
N/A

@severinbeauvais severinbeauvais added bug Something isn't working ENTITY Business Team NameX NameX and related services proxied via namex labels Jun 30, 2021
@jdyck-fw
Copy link
Collaborator

jdyck-fw commented Jul 9, 2021

This potentially might be addressed with the edit work that SRE team will be doing after NRO decommission.

@severinbeauvais
Copy link
Collaborator Author

Note: I'm not sure whether this is an API or UI issue. Because it's in Sentry, it means the error was generated in Namerequest UI. It appears the UI is trying to change a Rejected NR to In Progress !?!?

@jdyck-fw jdyck-fw added this to the Entities 10.1 milestone Jul 14, 2021
@jdyck-fw jdyck-fw modified the milestones: Entities 10.1, Entities 10.2 Jul 28, 2021
@vysakh-menon-aot vysakh-menon-aot self-assigned this Jul 30, 2021
@vysakh-menon-aot
Copy link
Collaborator

@severinbeauvais API tries to change the state to INPROGRESS only from checkout API call. At the same time the UI trigger the checkout API call only when the NR in DRAFT or INPROGRESS. Not sure how to reproduce it.

@severinbeauvais
Copy link
Collaborator Author

Thanks for the investigation.

According to Sentry, this error was last seen in release Name Reques v2.2.4 on July 8.

Therefore, if there is no additional information on this, I suggest we close this ticket. @lmcclung , do you agree?

@sienna-oldaccountdontuse
Copy link
Contributor

Blocked by 8442, which will fix sentry. We will keep this open until we can use sentry to investigate further.
FYI @kialj876 @Kaineatthelab

@lmcclung lmcclung removed this from the Entities 10.2 milestone Aug 9, 2021
@jdyck-fw jdyck-fw added the SRE SRE team task label Dec 2, 2021
@pwei1018 pwei1018 added Names Team Name Request Name Examination Team and removed SRE SRE team task labels Oct 6, 2023
@ozamani9gh
Copy link
Collaborator

Closing old ticket as per Severin's suggestion

This was referenced Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Something isn't working ENTITY Business Team Names Team Name Request Name Examination Team NameX NameX and related services proxied via namex Priority2
Projects
None yet
Development

No branches or pull requests

7 participants