Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COOP_UI: update Coops app favicon and title #857

Closed
WalterMoar opened this issue Jul 12, 2019 · 6 comments
Closed

COOP_UI: update Coops app favicon and title #857

WalterMoar opened this issue Jul 12, 2019 · 6 comments
Assignees
Labels
bug Something isn't working ENTITY Business Team Priority1

Comments

@WalterMoar
Copy link
Contributor

WalterMoar commented Jul 12, 2019

Describe the bug

The coops app is using the Vue logo, not the BC Gov logo, as the favicon. Also, the title should be changed from Coops to Cooperatives. At the same time, change the noscript message to also have Cooperatives, or perhaps just a generic "This web site..." message.

This should work on the typical browsers (Chrome, FF, IE11, Edge, Safari?).

To Reproduce
Steps to reproduce the behavior:

  1. Go to coops
  2. See favicon

Expected behavior

BC Gov sites should use BC Gov logo (the flying pants).

Screenshots

image.png

@JohnamLane
Copy link
Collaborator

Auth screen is missing the favicon in FireFox
IE11 has it on auth and dashboard, but loses it when you logout and get redirected back to /auth

@severinbeauvais
Copy link
Collaborator

@JohnamLane

  1. This is a sbc-auth issue. I had to update some of the 'special' public/img/icons because FF uses some of those.
  2. Did you try force-reloading the page (to refresh the cache) using CTRL+R? Actually I see this too, but I'm going to blame IE11 since it's their icon displaying (not the Vue icon) :P
  3. By the way, were you able to test on Safari (iOS or macOS)?

@severinbeauvais
Copy link
Collaborator

^^^ in fact, CTRL+R works to update the icon for the Coops UI, but is inconsistent for the Auth UI.

@severinbeauvais
Copy link
Collaborator

^^^ some quick research suggests that this is not uncommon with IE, going as far back as IE6. They say "deleting your browing history" helps, but it didn't work for me.

@Kaineatthelab I'm looking for a decision whether to pursue this any further. Thx!

@severinbeauvais
Copy link
Collaborator

Hmm, this may be related to another issue I'm seeing: after I login to dev, I don't get the latest code -- but if I refresh the page then I see the latest code changes.

I have cleared my browsing data (several times) (Chrome) and pressed CTRL+R several times, and I still see the issue.

Dunno, but this may become a problem for our users... Need to discuss this further. I'm leaving this ticket open for that reason.

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Aug 26, 2019

I opened ticket /#1148 for the caching issue.

As for the issue that this ticket resolved...

@JohnamLane wrote:

Auth screen is missing the favicon in FireFox
IE11 has it on auth and dashboard, but loses it when you logout and get redirected back to /auth

In both cases, it's the Auth UI incorrectly registering that icon with the browser (FF), not the Coops UI. So if the Coops UI displays the correct icon and title in our supported browsers then this ticket can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ENTITY Business Team Priority1
Projects
None yet
Development

No branches or pull requests

5 participants