Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7162 audit reporting validation rules #117

Merged
merged 3 commits into from
Aug 31, 2022
+3 −3
Merged

7162 audit reporting validation rules #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9846d57
7162: Addressed review comments
AnumehaSrivastava05 Aug 29, 2022
88f8926
7162: Corrected field name
AnumehaSrivastava05 Aug 29, 2022
e68a587
Corrected testcafe error message
AnumehaSrivastava05 Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/util/validators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,4 +306,4 @@ export const VALIDATE_GROUP_MEMBER_NUMBER_MESSAGE = 'Group Member Number is inva
export const VALIDATE_DEPARTMENT_NUMBER_MESSAGE = 'Department Number is invalid'
export const VALIDATE_POSTAL_CODE_MESSAGE = 'Postal Code is invalid'
export const VALIDATE_TELEPHONE_MESSAGE = 'Telephone is invalid. Only numbers 0 to 9 are valid. Phone Number must be entered as ten (10) numbers in length with no space or hyphen.'
export const VALIDATE_USER_ID_MESSAGE = 'UserId cannot be longer than 100 characters'
export const VALIDATE_USER_ID_MESSAGE = 'User ID cannot be longer than 100 characters'
2 changes: 1 addition & 1 deletion frontend/src/views/reports/AuditReporting.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export default {
} else if (this.result.records.length > 0) {
this.alertStore.setSuccessAlert('Transaction completed successfully')
} else {
this.alertStore.setErrorAlert('No results were returned. Please refine your search criteria and try again.')
this.alertStore.setWarningAlert('No results were returned. Please refine your search criteria and try again.')
}

this.searchOk = true
Expand Down
2 changes: 1 addition & 1 deletion frontend/tests/e2e/tests/reports/AuditReportingTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import AuditReportingPage from '../../pages/reports/AuditReportingPage'
import { regularAccUser } from '../../roles/roles'

const ERROR_MESSAGE = 'Please correct errors before submitting'
const USER_ID_EXCEEDS_LENGTH = 'UserId cannot be longer than 100 characters'
const USER_ID_EXCEEDS_LENGTH = 'User ID cannot be longer than 100 characters'
const START_DATE_REQUIRED_MESSAGE = 'Start Date is required'
const END_DATE_REQUIRED_MESSAGE = 'End Date is required'
const START_DATE_AFTER_END_DATE = 'Start Date should not be after End Date'
Expand Down