fix: persisting null value for a non-nullable field in affected party #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weskubo-cgi
requested changes
Dec 21, 2022
| @@ -46,6 +46,9 @@ protected Transaction transactionStart(HttpServletRequest request, TransactionTy | |||
| * @param identifier The value of the identifier | |||
| */ | |||
| protected void addAffectedParty(Transaction transaction, IdentifierType type, String identifier, AffectedPartyDirection direction) { | |||
| if (identifier == null || identifier.isBlank() || type == null || direction == null) { | |||
There was a problem hiding this comment.
You can use StringUtils.isEmpty() in place of the first two checks.
The type and direction checks are probably not required as the only reason this would happen is through bad coding. If you want to validate a method against bad usage you would typically throw an IllegalArgumentException though I don't think it's necessary in this case as we aren't using them consistently in the code base. Which isn't a horrible thing as this isn't library/api code.
If the identifier is null it also might be useful to add a logger.info message. That way there's a record of the fact that the auditing couldn't be done.
…ransaction-null-identity
weskubo-cgi
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.