Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8450 api security uses nonexistent permission #160

Merged
merged 3 commits into from
Dec 21, 2022
Merged

8450 api security uses nonexistent permission #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d68dcec
8450 api security uses nonexistent permission
prit-cgi Dec 19, 2022
ec6fac1
revert: ui comment change
prit-cgi Dec 19, 2022
d3e5925
Updated comment.
Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/main/java/ca/bc/gov/hlth/hnweb/security/SecurityConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ protected void configure(HttpSecurity http) throws Exception {
.mvcMatchers(HttpMethod.POST, "/group-member/update-number-and-dept").hasRole("UpdateNumberAndDept")
.mvcMatchers(HttpMethod.POST, "/msp-contracts/get-contract-periods").hasRole("GetContractPeriods")
.mvcMatchers(HttpMethod.POST, "/msp-contracts/update-contract-address").hasRole("UpdateContractAddress")
.mvcMatchers(HttpMethod.POST, "/msp-contracts/inquire-contract").hasAnyRole("ContractInquiry", "GetGroupMembersContractAddress") //inquire-contract endpoint will require this multi role as it is used by both R40 and R37 transactions
.mvcMatchers(HttpMethod.POST, "/msp-contracts/inquire-contract").hasAnyRole("ContractInquiry", "GetContractAddress") //inquire-contract endpoint will require this multi role as it is used by both R40 and R37 transactions
.mvcMatchers(HttpMethod.POST, "/patient-registration/get-patient-registration").hasRole("PatientRegistration")
.mvcMatchers(HttpMethod.GET, "/payee-mapping/").hasAnyRole("PatientRegistration", "ManageMSPPayeeNumber")
.mvcMatchers(HttpMethod.POST, "/payee-mapping").hasRole("ManageMSPPayeeNumber")
Expand Down
5 changes: 1 addition & 4 deletions frontend/src/views/mspcontracts/GetGroupMembersContractAddress.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,7 @@ export default {
this.showError()
return
}
/*
This screen calls the Contract Inquiry endpoint as the results shown here are a subset of those returned for Contract Inquiry. This does not
break security as currently all roles with permissions for R37(Get Group Member's Contract Address) also have permission for R40(Contract Inquiry).
*/
// This screen calls the Contract Inquiry endpoint as the results shown here are a subset of those returned for Contract Inquiry.
this.result = (await MspContractsService.inquireContract({ phn: this.phn, groupNumber: this.groupNumber })).data
if (this.result.status === 'error') {
this.alertStore.setErrorAlert(this.result.message)
Expand Down