Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1224 - Delegated Admin Table Disappears On Sign Out #1248

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix: #1224 - Delegated Admin Table Disappears On Sign Out #1248

merged 1 commit into from
Mar 19, 2024

Conversation

NickSaglioni
Copy link
Contributor

  • Fixed sign out bug by adding the missing "await" for the signOut promise, which was not blocking the code to wait for it's result, causing the cached data to be cleared before actually signing out.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed for 'nr-forests-access-management_admin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@NickSaglioni NickSaglioni merged commit ac24c9c into main Mar 19, 2024
10 checks passed
@NickSaglioni NickSaglioni deleted the fix/1224-delegated-admin-table-disappears-on-sign-out branch March 19, 2024 10:50
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MCatherine1994 MCatherine1994 MCatherine1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickSaglioni @MCatherine1994