feat: #1655 restrict client selection when d admins assign roles #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…dmins-assign-roles
ianliuwk1019
approved these changes
Dec 18, 2024
frontend/src/utils/AuthUtils.ts
Outdated
| @@ -2,6 +2,7 @@ import { | |||
| AdminRoleAuthGroup, | |||
| type AdminUserAccessResponse, | |||
| type FamAuthGrantDto, | |||
There was a problem hiding this comment.
man we need a linter installed
| fieldId: string; | ||
| }>(); | ||
|
|
||
| const { validate: validateForestClients } = useField(props.fieldId); |
There was a problem hiding this comment.
Not really sure how this validate works...
Just curious, how does useField(props.fieldId) know what to validate?
There was a problem hiding this comment.
Yes, it's validating the based on the field id provided
in this case it's forestClients inside the validation logic
|
craigyu
deleted the
feat/1655-restrict-client-selection-when-d-admins-assign-roles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1655
If the logged in user is a d-admin only, then show them only the FC they have permissions to add
Just one FC:
More than one:
Error state:
The "request access to it" feature is not implemented as we do not have enough information at the moment.
