feat: [NR-NMP-134] Calculate Nutrients Page #141
Conversation
lunamoonmoon
requested review from
fergmac,
PaulGarewal,
raarielgrace and
dallascrichmond
as code owners
| @@ -361,3 +361,5 @@ poetry.toml | |||
| pyrightconfig.json | |||
|
|
|||
| # End of https://www.toptal.com/developers/gitignore/api/node,java,python,go | |||
| .env.template | |||
There was a problem hiding this comment.
.env.templates should not be gitignored. The point of the templates is to let ppl know what the variable names are without letting them see the real deal. They should be synced to the repo.
| * @summary Type definition for fieldType File | ||
| */ | ||
|
|
||
| type fieldType = { |
There was a problem hiding this comment.
In most syntax, type names have each letter capitalized; they aren't camel-case.
Also, is this "field" like "a grass field"?
| */ | ||
|
|
||
| type fieldType = { | ||
| Fields: any[]; |
There was a problem hiding this comment.
Why is this any type? Also why does a Field have a Fields array? What does this object actually represent/which file does it correlate to?
| setFields(parsedData.years[0].Fields); | ||
| } | ||
| const parsedData = JSON.parse(state.nmpFile); | ||
| setFields(parsedData.years[0].Fields); |
There was a problem hiding this comment.
Is it safe to assume the index 0 here? Would someone ever be able to index into another year?
| </thead> | ||
| <tbody> | ||
| <td>Crops</td> | ||
| {/* {field.Crops.map((crop) => ( |
There was a problem hiding this comment.
Is there a reason to keep this commented-out code>?
| export default function FieldTable({ key, field, setFields }) { | ||
| const [isModalVisible, setIsModalVisible] = useState(false); | ||
|
|
||
| const fertilizerOptions = [ |
There was a problem hiding this comment.
You should be getting these options from the _FertilizerTypes__20241212 table.
Pull Request Standards
HOTFIX,FEATURE,etc][NMP-###]Description
This PR includes the following proposed change(s):
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: