Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

Update bcgov theme in compliance to WCAG 2.1 AA #50

Open
ShellyXueHan opened this issue Sep 13, 2019 · 12 comments
Open

Update bcgov theme in compliance to WCAG 2.1 AA #50

ShellyXueHan opened this issue Sep 13, 2019 · 12 comments
Assignees
Labels
enhancement stale issue Issue has not been updated for long.

Comments

@ShellyXueHan
Copy link
Contributor

No description provided.

@ShellyXueHan
Copy link
Contributor Author

@wenzowski any update on this?

@wenzowski
Copy link
Collaborator

@hamzajaved was looking at this and if I recall it got reprioritized. I would expect this to still be on our radar since we need to get the username/password authentication working in the bcgov theme at the same time.

@wenzowski
Copy link
Collaborator

@Maralsotoudehnia where did we land on reprioritizing this?

@Maralsotoudehnia
Copy link

@wenzowski @ShellyXueHan IIRC @hamzajaved mocked up some designs but then everyone got super busy and the work to implement changes turned out to be bigger than anticipated so it got deprioritized. Happy to pick this up again after we launch our app and the dust settles a bit. Maybe we can revive this collab in July/August? If so, it would be helpful to know what acceptance criteria Platform Services is looking for. I don't think it's effective to work without a shared understanding of what DoD would look like. Happy to chat.

@wenzowski
Copy link
Collaborator

@hamzajaved Is your design work ready to be posted publicly in this issue for peer review by #ux-guild?

@ShellyXueHan
Copy link
Contributor Author

It's great to hear about this! And yea agree with Alec to get some eyes on it. Also if you need some design details, see here

@hamzajaved
Copy link

Hey @ShellyXueHan. Yes, I have worked on the BCGov theme for KeyCloak login based on the XD you provided. Some notable updates:

  • All assets, types, colors, and spacing updated to be aligned with the BC Design system
  • Created a theme in XD for Typography, Colors, Components based on the BC Design System for easy usage. (I will make this more elaborate and share with BCDevHub as I believe it will be helpful for anyone looking to design using the BC Design System)
  • Updated base screen dimension to 1440 x 760 for more accurate prototype testing.
  • Designed to be easily responsive

The designs can be reviewed here:
https://xd.adobe.com/view/4d5292c8-b4ad-4a5d-7dec-d077dacd0f93-3b63/?fullscreen&hints=off

@ShellyXueHan
Copy link
Contributor Author

it's looking great! Let me know when you are ready to start implement. I'll setup the sandbox KeyCloak instance for you again (it's scaled down to reduce resource consumption).

@hamzajaved
Copy link

hamzajaved commented Jun 12, 2020

Login Options.xd.zip

I have attached my working XD file. It's ready for review by #ux-guild. @dlevineBC, you will see that I've converted components, type, and colors into usable classes in the XD. Let me know if that is helpful.

@dlevineBC
Copy link

Looks great!

@wenzowski
Copy link
Collaborator

Where do we expect the “I’m an admin” links to go?

Love the “Get a BCeID” button. I recall we were informed there’s no way to set a return redirect on that signup process. Maybe that button should open a new window with some indication of the altered behaviour (eg new window icon).

@wenzowski
Copy link
Collaborator

Are the FAQs/IDP guidance intended to be configurable? Can we standardize them and bake approved copy directly into the theme?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement stale issue Issue has not been updated for long.
Projects
None yet
Development

No branches or pull requests

5 participants