Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove larger text and bold on "Relationship" links #149

Closed
swcurran opened this issue Feb 14, 2022 · 2 comments · Fixed by #154 or #159
Closed

Remove larger text and bold on "Relationship" links #149

swcurran opened this issue Feb 14, 2022 · 2 comments · Fixed by #154 or #159
Assignees

Comments

@swcurran
Copy link
Contributor

For example, on: https://test.orgbook.gov.bc.ca/entity/FM0239928b

The link for the owning entity "WESTCOAST HOBBIES 4 U LTD." is in (I think) a larger font and bold. I don't think that is needed.

I suggest also making it a bulleted (unordered) list vs. just a line of text.

When done locally, please add screenshots before PRing this change.

Thanks

@wadeking98
Copy link
Contributor

Bullets on relationship credentials
image
Bullets on expired relationship credentials
image

@swcurran
Copy link
Contributor Author

The "owned" by does not have the bullet (see below). It should be every relationship is displayed the same way. While in there, I think we should ditch any explicit
between the "Credential Expired..." and the link to the relationship entity (see screenshot above). If it is just a natural line wrapping that is OK, but if it is an explicit line break, I think it should be removed.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants