Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression -- being able to search for all credentials of a given type #70

Closed
swcurran opened this issue Dec 15, 2021 · 6 comments · Fixed by #134
Closed

Regression -- being able to search for all credentials of a given type #70

swcurran opened this issue Dec 15, 2021 · 6 comments · Fixed by #134
Assignees
Labels
priority for cleanup This issue is a priority for a cleanup pass.

Comments

@swcurran
Copy link
Contributor

In the Old OrgBook UI, the advanced search feature has commonly used in demos to find a company with a specific type of credential. This is probably the only use of the "advanced search". Not particularly useful, but great for demos when you don't know the names of companies that have a specific type of credential. We (and especially @watkinspd and @jljordan42 ) would like that "Show me a list of companies with a given credential".

One idea for doing that, might be on this screen (image below), where we show all the credential types. Could the credential types be a link or perhaps have a "magnifying glass" search icon beside them that when clicked went to the search screen showing a list of that credential type.

Open to other ideas of how to get this feature back. Will it screw up the new search screen (because its using a different API or search parameters), or can we get to the search screen in that context?

image

@swcurran
Copy link
Contributor Author

Not a showstopper for launch, but would definitely like to know if the new search results screen can be retrofitted to do this type of search if we can find a good place from which to trigger it?

@swcurran swcurran assigned wadeking98 and unassigned amanji Jan 11, 2022
@swcurran
Copy link
Contributor Author

@wadeking98 -- priority for cleanup.

@WadeBarnes WadeBarnes added the priority for cleanup This issue is a priority for a cleanup pass. label Jan 18, 2022
@wadeking98
Copy link
Contributor

I took the approach of just having a dropdown menu instead of a page with links. It seems simpler and more user friendly to me

@swcurran
Copy link
Contributor Author

I'm sure it is fine -- but can I see a screen shot?

@wadeking98
Copy link
Contributor

image
image
image

@swcurran
Copy link
Contributor Author

This is not ideal for a number of reasons:

  • Where this goes (search by credential type) is not an expected definition of "Advanced Search". One of the findings of the UX Research was that the feature was confusing, and by just having "Search by Credential Type" it's even less "advanced".
  • The feature is really only used to demonstrate certain credentials. It's not a feature "real users" have a lot of use for.
  • Based on the first two items -- we don't want this on the main page.

Someday we may implement a true "Advanced Search", but this ain't it :-).

Please revert this and implement the approach described in the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority for cleanup This issue is a priority for a cleanup pass.
Projects
None yet
4 participants