From 0770558ffd003a77b66f387190d3778a19640e38 Mon Sep 17 00:00:00 2001 From: Sumesh Punakkal Kariyil Date: Fri, 12 Feb 2021 23:05:24 -0800 Subject: [PATCH 1/2] Updating sonar file to include the notifications api --- sonar-runner/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sonar-runner/build.gradle b/sonar-runner/build.gradle index efadffef4..f9b515571 100644 --- a/sonar-runner/build.gradle +++ b/sonar-runner/build.gradle @@ -13,7 +13,7 @@ sonarqube { property "sonar.projectName", "Queue Management" property "sonar.projectKey", "org.sonarqube:queue-management" property "sonar.projectBaseDir", "../" - property "sonar.sources", "./api,./frontend/src,./appointment-frontend/src,/jobs/appointment_reminder" + property "sonar.sources", "./api,./frontend/src,./appointment-frontend/src,./jobs/appointment_reminder,./notifications-api" property "sonar.exclusions", "**/test_*.py" property "sonar.verbose", "true" property "sourceEncoding", "UTF-8" From 163b0da7c0aa7974db0007bb414e05802943609f Mon Sep 17 00:00:00 2001 From: Sumesh Punakkal Kariyil Date: Mon, 15 Feb 2021 22:04:30 -0800 Subject: [PATCH 2/2] Fixing issue when sms is disabled in PROD --- .../resources/bookings/appointment/appointment_reminder_get.py | 1 + 1 file changed, 1 insertion(+) diff --git a/api/app/resources/bookings/appointment/appointment_reminder_get.py b/api/app/resources/bookings/appointment/appointment_reminder_get.py index 86ff7d30d..65c6530ff 100644 --- a/api/app/resources/bookings/appointment/appointment_reminder_get.py +++ b/api/app/resources/bookings/appointment/appointment_reminder_get.py @@ -40,6 +40,7 @@ def get(self, reminder_type: str = 'email'): if appointments: for (appointment, office, timezone, user) in appointments: send_reminder = False + user_telephone = None if reminder_type == 'email': if user and user.send_email_reminders: send_reminder = True