Fix parsing booleans

Closes #71
yargs · Sep 29, 2012 · ee692b3 · ee692b3
1 parent f28c0e6
commit ee692b3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -344,7 +344,7 @@ function Argv (args, cwd) {
                     setArg(key, next);
                     i++;
                 }
-                else if (/true|false/.test(next)) {
+                else if (/^(true|false)$/.test(next)) {
                     setArg(key, next === 'true');
                     i++;
                 }

diff --git a/test/parse.js b/test/parse.js
@@ -418,3 +418,16 @@ test('boolean and alias using explicit true', function (t) {
     t.end();
 });
 
+// regression, see https://github.com/substack/node-optimist/issues/71
+test('boolean and --x=true', function(t) {
+    var parsed = optimist(['--boool', '--other=true']).boolean('boool').argv;
+
+    t.same(parsed.boool, true);
+    t.same(parsed.other, 'true');
+
+    parsed = optimist(['--boool', '--other=false']).boolean('boool').argv;
+
+    t.same(parsed.boool, true);
+    t.same(parsed.other, 'false');
+    t.end();
+});