Locale French #215
Merged
Locale French #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks @LoicMahieu! I would say the types could go either way - whatever is most familiar to French-speaking peoples. At least |
|
@LoicMahieu I'm really happy with this, do you think it's ready to merge? we can allow others to edit after the fact. |
LoicMahieu
force-pushed
the
feature/translate-fr
branch
from
9dee0d9
to
7bb5986
Compare
|
Review done! There were some mistakes, thankfully corrected. Types are finally translated, people I asked were comfortable with the translation. |
|
Awesome thank you @LoicMahieu! |
|
@LoicMahieu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yargsgo international !Related to #214
Added french language. Still work in progress. I would like some review from other french speaking people. I'll ask my colleagues but it'll be most better if community can review it too.
Is it a good idea to translate types ?
I wasn't confortable to translate this kind of words, closely linked with programming and computer science. In current review, it is not translated.