Add missing locale strings to y18n lookup #221
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➕ Further testing revealed the following strings used in
index.js
were missing from y18n lookup:This PR fixes that.
Note that the first commit takes the naive approach, which results in using the
en
version for'Show help'
in this scenario:The second commit addresses this by deferring the y18n lookup until the whole usage content is generated, instead of doing it when the option is defined.
Also note that this PR does not attempt to address the problem of updating locale strings before the desired locale is set (if it even is a problem):
See related discussion in PR #220.