Reinstate os-locale with option to prohibit spawning #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bcoe When you get a chance, this PR needs review. Thanks! |
|
awesome \o/ will make the time this evening. |
|
Great work 😎, |
nexdrew
pushed a commit
that referenced
this pull request
Sep 4, 2015
Reinstate os-locale with option to prohibit spawning
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os-locale@1.3.1allows us to nuke the previous stop-gap solution. Now we can tellos-localenot to spawn any subprocesses, so we don't introduce unnecessary latency or, even worse, problems with installingspawn-sync, for downstream dependents like Atom. 😎If the build fails due to
standardproblems, anything not handled by PR #247 will be subsequently fixed here.