completion: support promises #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LinusU this looks solid, I'll look a bit closer tonight when I'm not at work. |
| process.emit = function (ev, value) { | ||
| if (ev === 'uncaughtException') { | ||
| done() | ||
| cb(value) |
There was a problem hiding this comment.
Anything wrong with changing this to cb(value, done()) instead?
There was a problem hiding this comment.
Not really, didn't want it to also return the result thought. I don't think it's best practice to include both error and result, and with the move towards promises it won't be possible anymore.
|
LGTM 👍 Thanks, @LinusU! |
|
No problems, happy to help! |
|
@LinusU your work is published to yargs' next release candidate, give it a shot:
Assuming we don't run into any issues, I'll promote the release tomorrow. |
|
Super! Thanks \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #278
I had to rework the helper to support async tests since promises defer things to the next tick, and since I have to use
nextTickas to not swallow any fatal errors and just never report them.A promise polyfill is included as a **dev-**dependency and is used during the tests.