Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle tileset margins and spacing #59

Closed
bcvery1 opened this issue Mar 27, 2019 · 2 comments
Closed

Handle tileset margins and spacing #59

bcvery1 opened this issue Mar 27, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@bcvery1
Copy link
Owner

bcvery1 commented Mar 27, 2019

TileSets can have margins and tile spacing. This is currently unhandled, so tile sprites will be incorrect if either of these values are set.

The calculation is done in utilities.go, but the calling code is in tile.go in the function Draw which already takes a *Tileset parameter, shouldn't be difficult to calculate the offsets

@bcvery1 bcvery1 added the enhancement New feature or request label Mar 27, 2019
@bcvery1 bcvery1 added this to the v0.4.0 release milestone Mar 27, 2019
@perber
Copy link

perber commented Apr 6, 2019

Hello, I`m actually using your library and I would like to create a PR which adresses this issue. My map is currently using a 1pixel spacing.

@bcvery1
Copy link
Owner Author

bcvery1 commented Apr 8, 2019

Hi @perber - sorry about getting back to this so late! That's great to hear that TilePix is being used.

Hopefully we can get your PR merged soon so you can make use of the spacing on your tileset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants