Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on non-orthogonal maps #79

Open
bcvery1 opened this issue Apr 5, 2019 · 2 comments
Open

Error on non-orthogonal maps #79

bcvery1 opened this issue Apr 5, 2019 · 2 comments
Labels
enhancement New feature or request good first issue A simple issue that would be good for a newcomer priority:medium Required for this release

Comments

@bcvery1
Copy link
Owner

bcvery1 commented Apr 5, 2019

TilePix only supports orthogonal maps (currently - hopefully we'll be able to support other types in the future). A sensible error should be returned on Reading a map which doesn't have orientation="orthogonal".

Need to set up a constant for each type:

  • orthogonal
  • hexagonal
  • isometric
  • staggered

Then, using a switch statement, check against each, returning an error if not supported, and returning a different error if default because it is an unrecognised format.

@bcvery1 bcvery1 added the enhancement New feature or request label Apr 5, 2019
@bcvery1 bcvery1 added this to the v0.4.0 release milestone Apr 5, 2019
@bcvery1 bcvery1 added good first issue A simple issue that would be good for a newcomer priority:medium Required for this release and removed priority:medium Required for this release labels Apr 9, 2019
@NullDefault
Copy link

Are there perchance any recommended workarounds to using isometric maps? Alternatively, which parts of the code would need to be updated to support non-orthogonal maps?

@bcvery1
Copy link
Owner Author

bcvery1 commented Dec 7, 2020

Hey, I'm not sure what code would need to be changed unfortunately, this has not yet been investigated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue A simple issue that would be good for a newcomer priority:medium Required for this release
Projects
None yet
Development

No branches or pull requests

2 participants