Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: animation API (work in progress) #467

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

feat: animation API (work in progress) #467

wants to merge 38 commits into from

Conversation

bdunderscore
Copy link
Owner

No description provided.

bdunderscore
bdunderscore commented Oct 28, 2024
View reviewed changes
Editor/API/AnimatorServices/ECBComparator.cs

namespace nadena.dev.ndmf.animator
{
internal class ECBComparator : IComparer<EditorCurveBinding>, IEqualityComparer<EditorCurveBinding>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? (Can we just use the built in comparator?)

bdunderscore
bdunderscore commented Nov 7, 2024
View reviewed changes
Editor/API/AnimatorServices/VirtualClip.cs Outdated

VirtualClip refPoseClip = null;
var settings = AnimationUtility.GetAnimationClipSettings(clip);
if (settings.additiveReferencePoseClip != null)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protect against recursion

@bdunderscore
Copy link
Owner Author

bdunderscore commented Nov 10, 2024 •
edited
Loading

TODO

  • Make Clone/Create APIs consistent

  • Implement handling for VRChat-specific state behaviours (and tests)

  • Add tests for platform bindings

  • Add tests for ObjectPathRemapper

  • Remove ECBComparator

  • Make IDisposable pattern more consistent

  • Add caching to AnimationServicesContext

  • Add support for extension context dependencies
    ======
    For porting over MA:

  • Move transform lookthrough path support to a separate pass

@anatawa12
Copy link
Contributor

比較的独立したAPIなので#nullable enableしてくれると嬉しいかもです

@bdunderscore
Copy link
Owner Author

Clone/Create:

  • Clone will be via CloneContext only
  • Create will be supported on individual classes, and will take CloneContext and name.

@bdunderscore bdunderscore force-pushed the anim-api branch 2 times, most recently from ef889f5 to 4fdaae7 Compare November 19, 2024 04:09
@bdunderscore bdunderscore marked this pull request as ready for review November 19, 2024 04:09
@bdunderscore bdunderscore linked an issue Nov 28, 2024 that may be closed by this pull request
Implement Animator/Animation Parser #427
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Animator/Animation Parser
2 participants
@bdunderscore @anatawa12