Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Makie compat #112

Merged
merged 3 commits into from
Jul 23, 2024
Merged

bump Makie compat #112

merged 3 commits into from
Jul 23, 2024

Conversation

ericphanson
Copy link
Member

No description provided.

@ericphanson ericphanson requested a review from palday July 23, 2024 11:02
@palday
Copy link
Member

palday commented Jul 23, 2024

docs build is erroring because Makie no longer ignores invalid kwargs. I haven't looked more closely yet but I suspect we're just forwarding all kwargs to all plots even when some kwargs only apply to some plots.

@ericphanson
Copy link
Member Author

Invalid attribute makersize 🙃

@palday
Copy link
Member

palday commented Jul 23, 2024

now markerstrokewidth 😞

Copy link
Member

@palday palday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ericphanson ericphanson merged commit 2a4494e into main Jul 23, 2024
9 checks passed
@ericphanson ericphanson deleted the eph/bump-makie branch July 23, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants