WIP: Add Financial Times price source #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any ideas? The code itself is done, so maybe just go for something quick right now? |
|
Since it's been a while, can this just be merged? The info is not very important and can be added later through a seperate PR. |
|
@ThomasdenH this is a great work for users especially in UK. just wondering how did you get an API Key from FT as an individual user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Financial Times API as a price source, which closes #1.
I have marked this as WIP because the source wasn't yet added to the Readme. I'm not sure what the 'Provides prices for' and 'Base currency' should say, so is there anyone who can help out there?