Put locales into config-files (yaml)

[axsapronov]

I think locales in .py is bad practice, because locale is class with ONE method (__init__).

My suggestion: put locales into yaml-files.

[bear]

would locales then become parameters to the main call?
Can you work up what this would look like as a PR?

[axsapronov]

Ok, I write this code

[axsapronov]

I tried. There is no result. I will still try

[bear]

no worries - I appreciate you wanting to solve this

[philiptzou]

The yaml files will introduce new dependency to PyYAML. I don't like the new dependency (which means you had to compile PyYAML before pdt get installed).

[bear]

my thought about that would be to take the work of converting it to YAML and then see if that could be done as JSON.

another option would be to make the PyYAML part only something that would have to be done during the build process -- i.e. generate the data that would be used during normal pdt use by reading and processing the PyYAML

[axsapronov]

You can find my code in branch yaml_locales

[bear]

thanks @warmonger1 !

[axsapronov]

@bear, in branch yaml_locales - many yaml files, but not all tests pass

[philiptzou]

@warmonger1 I agreed with your opinion that .py with class is bad practice. But whether YAML or JSON they all share two disadvantages that are: the unserialization reduces performance, also the flexibility of YAML || JSON are both lower than .py files. So I'm thinking about other pure Python built-in solutions. Especially a few of .py files like Django settings.py but not using class. I'll write another version about this thought and let's discuss on these two solutions.

[bear]

@philiptzou - looking forward to a .py solution that covers the concern that @warmonger1 raised

[philiptzou]

I did the modification in #130 which based on @warmonger1's changes.

yaml_locales...philiptzou:alt_locales

[axsapronov]

Sorry, now i have many works :( I can't create full pull request with this feature.
We can base on PR #130 by @philiptzou

[philiptzou]

@warmonger1 you can push it to your folked repository and you can create pull-request. It's a bit easier for us to review every lines you changed. Feel free to modify anything based on #130.

[bear]

edited: removed blocking comment

[philiptzou]

@warmonger1 Will you add new changes for this issue? Or this issue is solved and can be closed?

[bear]

oh right, this may not be blocking v2 anymore - i'll remove it for now and we can add it back if needed