Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to indent "inner HTML"... #312

Merged
merged 2 commits into from
Aug 15, 2013
Merged

add option to indent "inner HTML"... #312

merged 2 commits into from
Aug 15, 2013

Conversation

jonschlinkert
Copy link
Contributor

Since <head> and <body> section are no longer indented by default. (I noticed indent_content was defaulted to false couple of months ago. I prefer inner HTML to be indented personally, so hopefully this is cool to add back in - but my apologies in advance if there were other reasons this was removed.)

@bitwiseman
Copy link
Member

Thanks for this!
If we had tests for the html beautifier, I'd ask you to add tests for it. :)

@jonschlinkert
Copy link
Contributor Author

no problem, thanks for this great tool

@bitwiseman
Copy link
Member

In the next week or so, I'll add the test infrastructure for the html beautifier and add a test for this and merge this at that point.

@jonschlinkert
Copy link
Contributor Author

Great, thanks!

On Tue, Jul 30, 2013 at 1:42 AM, Liam Newman notifications@git.luolix.topwrote:

In the next week or so, I'll add the test infrastructure for the html
beautifier and add a test for this and merge this at that point.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/312#issuecomment-21770764
.

Jon Schlinkert
Core Team, LESS/Less.js
CEO, Sellside, Inc.
(513) 616-4335

github.com/jonschlinkert
linkedin.com/in/jonschlinkert http://www.linkedin.com/in/jonschlinkert
twitter.com/jonschlinkert http://www.twitter.com/jonschlinkert

@jonschlinkert
Copy link
Contributor Author

Hey, since I use this on most assemble projects and boilerplates, was just checking in to see if you were planning to merge soon. thanks!

bitwiseman added a commit that referenced this pull request Aug 15, 2013
@bitwiseman
Merge pull request #312 from jonschlinkert/master
7a33968 
add option to indent "inner HTML"...
@bitwiseman bitwiseman merged commit 7a33968 into beautifier:master Aug 15, 2013
@bitwiseman
Copy link
Member

This seems like a pretty contained change. I'll go ahead and merge.

@jonschlinkert
Copy link
Contributor Author

👍 awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonschlinkert @bitwiseman