The indent_with_tabs option did not work when required in node, only CLI. #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We probably need equivalent behavior and tests on the python side. Please add them, and I'll be happy to merge. |
|
Seems it's already implemented correctly in python https://github.com/einars/js-beautify/blob/master/python/jsbeautifier/__init__.py#L238 But yeah, no tests. I'll add it. |
|
That fine? |
|
Yup. That's great. Thanks! |
bitwiseman
added a commit
that referenced
this pull request
Aug 27, 2013
The indent_with_tabs option did not work when required in node, only CLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it does, added tests as well. And removed the check from the CLI. Noticed this when using it from grunt-jsbeautifier.