import errno for errno.EEXIST #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this required for script to work? If so, pleas add a test that exercises the code path that uses this. If not, we should not add it. |
|
Yes this is required, this is what I get on Ubuntu 13.10 $ js-beautify -o /dev/null - So the test is just running the script :) |
|
which version of python is on that system? |
|
Our travis-ci uses to 2.7.3. I'll got ahead and merge, as it doesn't break the existing scenarios. |
bitwiseman
added a commit
that referenced
this pull request
Nov 7, 2013
import errno for errno.EEXIST
|
Thanks :) I suppose 2.7.4 or 2.7.5 removed an implicit import errno from one of the modules? |
|
Released 1.4.2, please try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.